refactor get_influx for performance
#1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SouthEndMusic
changed the title
get_influx for performance
|
Without this PR:
With this PR:
|
|
It does look like the HWS model is still quite a bit slower than before. That can be due to a few things:
|
Jingru923
approved these changes
Aug 27, 2024
| vertical_flux[n + basin_idx] + # evaporation | ||
| vertical_flux[2n + basin_idx] - # drainage | ||
| vertical_flux[3n + basin_idx] # infiltration | ||
| end |
There was a problem hiding this comment.
Can you add the keyword return? So it makes the function more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #1606.
Hopefully fixes the runtime of the HWS model.